Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2025-03-24 08:08:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Replace modular_frost::Curve::hash_to_vec with just hash

Browse source 
There's no reason to copy it to a heap allocated value. The Output implements
AsRef<[u8]> and all uses are satisfied by that.
This commit is contained in:
Luke Parker 2022-12-13 19:32:46 -05:00
parent 783a445a3e
commit 2b042015b5
No known key found for this signature in database
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
crypto/frost/src/curve/mod.rs
View file

@ -6,7 +6,7 @@ use rand::{RngCore, CryptoRng};
use zeroize::{Zeroize, Zeroizing}; use zeroize::{Zeroize, Zeroizing};
use subtle::ConstantTimeEq; use subtle::ConstantTimeEq;
use digest::Digest; use digest::{Digest, Output};
use group::{ use group::{
ff::{Field, PrimeField}, ff::{Field, PrimeField},
@ -41,8 +41,8 @@ pub trait Curve: Ciphersuite {
const CONTEXT: &'static [u8]; const CONTEXT: &'static [u8];
/// Hash the given dst and data to a byte vector. Used to instantiate H4 and H5. /// Hash the given dst and data to a byte vector. Used to instantiate H4 and H5.
fn hash_to_vec(dst: &[u8], data: &[u8]) -> Vec<u8> { fn hash(dst: &[u8], data: &[u8]) -> Output<Self::H> {
Self::H::digest([Self::CONTEXT, dst, data].concat()).as_ref().to_vec() Self::H::digest([Self::CONTEXT, dst, data].concat())
} }
/// Field element from hash. Used during key gen and by other crates under Serai as a general /// Field element from hash. Used during key gen and by other crates under Serai as a general
@ -53,13 +53,13 @@ pub trait Curve: Ciphersuite {
} }
/// Hash the message for the binding factor. H4 from the IETF draft. /// Hash the message for the binding factor. H4 from the IETF draft.
fn hash_msg(msg: &[u8]) -> Vec<u8> { fn hash_msg(msg: &[u8]) -> Output<Self::H> {
Self::hash_to_vec(b"msg", msg) Self::hash(b"msg", msg)
} }
/// Hash the commitments for the binding factor. H5 from the IETF draft. /// Hash the commitments for the binding factor. H5 from the IETF draft.
fn hash_commitments(commitments: &[u8]) -> Vec<u8> { fn hash_commitments(commitments: &[u8]) -> Output<Self::H> {
Self::hash_to_vec(b"com", commitments) Self::hash(b"com", commitments)
} }
/// Hash the commitments and message to calculate the binding factor. H1 from the IETF draft. /// Hash the commitments and message to calculate the binding factor. H1 from the IETF draft.