Ecosystem/serai
Ecosystem/serai
1
0
Fork 0
mirror of https://github.com/serai-dex/serai.git synced 2024-09-28 17:31:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Correct panic possible when jumping to a round with Precommit(None)

Browse source
This commit is contained in:
Luke Parker 2023-10-18 16:46:14 -04:00
parent 9accddb2d7
commit 041ed46171
No known key found for this signature in database
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
coordinator/tributary/tendermint/src/lib.rs
View file

@ -544,7 +544,8 @@ impl<N: Network + 'static> TendermintMachine<N> {
}
}
// Returns Ok(true) if this was a Precommit which had its signature validated
// Returns Ok(true) if this was a Precommit which had either no signature or its signature
// validated
// Returns Ok(false) if it wasn't a Precommit or the signature wasn't validated yet
// Returns Err if the signature was invalid
fn verify_precommit_signature(
@ -552,7 +553,8 @@ impl<N: Network + 'static> TendermintMachine<N> {
signed: &SignedMessageFor<N>,
) -> Result<bool, TendermintError<N>> {
let msg = &signed.msg;
if let Data::Precommit(Some((id, sig))) = &msg.data {
if let Data::Precommit(precommit) = &msg.data {
let Some((id, sig)) = precommit else { return Ok(true) };
// Also verify the end_time of the commit
// Only perform this verification if we already have the end_time
// Else, there's a DoS where we receive a precommit for some round infinitely in the future