serai/processor/ethereum/deployer/contracts/Deployer.sol

89 lines
3.9 KiB
Solidity
Raw Normal View History

2024-09-15 21:13:10 +00:00
// SPDX-License-Identifier: AGPL-3.0-only
pragma solidity ^0.8.26;
/*
2024-10-31 01:35:43 +00:00
The expected deployment process of Serai's Router is as follows:
2024-09-15 21:13:10 +00:00
1) A transaction deploying Deployer is made. Then, a deterministic signature is
created such that an account with an unknown private key is the creator of
the contract. Anyone can fund this address, and once anyone does, the
transaction deploying Deployer can be published by anyone. No other
transaction may be made from that account.
2) Anyone deploys the Router through the Deployer. This uses a sequential nonce
such that meet-in-the-middle attacks, with complexity 2**80, aren't feasible.
While such attacks would still be feasible if the Deployer's address was
controllable, the usage of a deterministic signature with a NUMS method
prevents that.
This doesn't have any denial-of-service risks and will resolve once anyone steps
forward as deployer. This does fail to guarantee an identical address across
every chain, though it enables letting anyone efficiently ask the Deployer for
the address (with the Deployer having an identical address on every chain).
Unfortunately, guaranteeing identical addresses aren't feasible. We'd need the
Deployer contract to use a consistent salt for the Router, yet the Router must
be deployed with a specific public key for Serai. Since Ethereum isn't able to
determine a valid public key (one the result of a Serai DKG) from a dishonest
public key, we have to allow multiple deployments with Serai being the one to
determine which to use.
The alternative would be to have a council publish the Serai key on-Ethereum,
with Serai verifying the published result. This would introduce a DoS risk in
the council not publishing the correct key/not publishing any key.
2024-09-20 06:12:26 +00:00
2024-10-31 01:35:43 +00:00
This design does not work (well) with contracts expecting initialization due
to only allowing deploying init code once (which assumes contracts are
distinct via their constructors). Such designs are unused by Serai so that is
accepted.
2024-09-15 21:13:10 +00:00
*/
2024-10-31 01:35:43 +00:00
/// @title Deployer of contracts for the Serai network
/// @author Luke Parker <lukeparker@serai.exchange>
2024-09-15 21:13:10 +00:00
contract Deployer {
2024-10-31 01:35:43 +00:00
/// @return The deployment for some (hashed) init code
mapping(bytes32 => address) public deployments;
2024-09-15 21:13:10 +00:00
2024-10-31 01:35:43 +00:00
/// @notice Raised if the provided init code was already prior deployed
2024-09-15 21:13:10 +00:00
error PriorDeployed();
2024-10-31 01:35:43 +00:00
/// @notice Raised if the deployment fails
2024-09-15 21:13:10 +00:00
error DeploymentFailed();
2024-10-31 01:35:43 +00:00
/// @notice Deploy the specified init code with `CREATE`
/// @dev This init code is expected to be unique and not prior deployed
/// @param initCode The init code to pass to `CREATE`
function deploy(bytes memory initCode) external {
2024-09-15 21:13:10 +00:00
// Deploy the contract
2024-10-31 01:35:43 +00:00
address createdContract;
// slither-disable-next-line assembly
2024-09-15 21:13:10 +00:00
assembly {
2024-10-31 01:35:43 +00:00
createdContract := create(0, add(initCode, 0x20), mload(initCode))
2024-09-15 21:13:10 +00:00
}
2024-10-31 01:35:43 +00:00
if (createdContract == address(0)) {
2024-09-15 21:13:10 +00:00
revert DeploymentFailed();
}
2024-10-31 01:35:43 +00:00
bytes32 initCodeHash = keccak256(initCode);
2024-10-31 01:35:43 +00:00
/*
Check this wasn't prior deployed.
This is a post-check, not a pre-check (in violation of the CEI pattern). If we used a
pre-check, a deployed contract could re-enter the Deployer to deploy the same contract
multiple times due to the inner call updating state and then the outer call overwriting it.
The post-check causes the outer call to error once the inner call updates state.
This does mean contract deployment may fail if deployment causes arbitrary execution which
maliciously nests deployment of the being-deployed contract. Such an inner call won't fail,
yet the outer call would. The usage of a re-entrancy guard would call the inner call to fail
while the outer call succeeds. This is considered so edge-case it isn't worth handling.
*/
if (deployments[initCodeHash] != address(0)) {
revert PriorDeployed();
}
// Write the deployment to storage
2024-10-31 01:35:43 +00:00
deployments[initCodeHash] = createdContract;
2024-09-15 21:13:10 +00:00
}
}