Fixed Coverity errors

2024-12-22 19:39:22 +00:00 · 2024-06-23 23:51:47 +02:00 · 2024-06-23 23:51:47 +02:00 · 24f2ed2f81
commit 24f2ed2f81
parent a75cf652de
2 changed files with 4 additions and 2 deletions
--- a/src/crypto.cpp
+++ b/src/crypto.cpp
@ -37,7 +37,9 @@ class RandomBytes
 public:
 	RandomBytes() : rng(RandomDeviceSeed::instance), dist(0, 255)
 	{
-		uv_mutex_init_checked(&m);
+		if (uv_mutex_init(&m) != 0) {
+			abort();
+		}

 		// Diffuse the initial state in case it has low quality
 		rng.discard(10000);
--- a/src/p2p_server.cpp
+++ b/src/p2p_server.cpp
@ -178,7 +178,7 @@ void P2PServer::clear_cached_blocks()
 		return;
 	}

-	for (auto it : *m_cachedBlocks) {
+	for (const auto& it : *m_cachedBlocks) {
 		delete it.second;
 	}