Ecosystem/p2pool
1
0
Fork 0
mirror of https://github.com/SChernykh/p2pool.git synced 2024-11-17 00:07:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

JSONRPCRequest: fixed undefined behavior in the error handler

Browse source
This commit is contained in:
SChernykh 2021-11-10 16:26:01 +01:00
parent 5dd8d11b72
commit 07cfb54bdc
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/json_rpc_request.h
View file

@ -36,10 +36,11 @@ public:
static FORCEINLINE void call(const char* address, int port, const char* req, T&& cb, U&& close_cb) static FORCEINLINE void call(const char* address, int port, const char* req, T&& cb, U&& close_cb)
{ {
// It will be deleted in one of the tcp callbacks eventually // It will be deleted in one of the tcp callbacks eventually
JSONRPCRequest* r = new JSONRPCRequest(address, port, req, new Callback<T>(std::move(cb)), new Callback<U>(std::move(close_cb))); CallbackBase* close_callback = new Callback<U>(std::move(close_cb));
JSONRPCRequest* r = new JSONRPCRequest(address, port, req, new Callback<T>(std::move(cb)), close_callback);
if (!r->m_valid) { if (!r->m_valid) {
constexpr char err[] = "internal error"; constexpr char err[] = "internal error";
close_cb(err, sizeof(err) - 1); (*close_callback)(err, sizeof(err) - 1);
delete r; delete r;
} }
} }