Ecosystem/haveno
Ecosystem/haveno
2
1
Fork 0
mirror of https://github.com/haveno-dex/haveno.git synced 2024-12-22 19:49:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

log stack traces at warn or error level
Some checks are pending
CI / build (macos-13) (push) Waiting to run
Details
CI / build (ubuntu-latest) (push) Waiting to run
Details
CI / build (windows-latest) (push) Waiting to run
Details
Codacy Coverage Reporter / Publish coverage (push) Waiting to run
Details
CodeQL / Analyze (push) Waiting to run
Details

Browse source
This commit is contained in:
woodser 2024-09-20 11:03:33 -04:00
parent 8d55abe3b9
commit 50f3bd510a
42 changed files with 117 additions and 138 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apitest/src/main/java/haveno/apitest/ApiTestMain.java
View file

@ -78,7 +78,7 @@ public class ApiTestMain {
} catch (Throwable ex) { } catch (Throwable ex) {
err.println("Fault: An unexpected error occurred. " + err.println("Fault: An unexpected error occurred. " +
"Please file a report at https://haveno.exchange/issues"); "Please file a report at https://github.com/haveno-dex/haveno/issues");
ex.printStackTrace(err); ex.printStackTrace(err);
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }

1
build.gradle
View file

@ -334,6 +334,7 @@ configure(project(':p2p')) {
implementation "com.google.protobuf:protobuf-java:$protobufVersion" implementation "com.google.protobuf:protobuf-java:$protobufVersion"
implementation "org.fxmisc.easybind:easybind:$easybindVersion" implementation "org.fxmisc.easybind:easybind:$easybindVersion"
implementation "org.slf4j:slf4j-api:$slf4jVersion" implementation "org.slf4j:slf4j-api:$slf4jVersion"
implementation "org.apache.commons:commons-lang3:$langVersion"
implementation("com.github.haveno-dex.netlayer:tor.external:$netlayerVersion") { implementation("com.github.haveno-dex.netlayer:tor.external:$netlayerVersion") {
exclude(module: 'slf4j-api') exclude(module: 'slf4j-api')
} }

2
common/src/main/java/haveno/common/app/Log.java
View file

@ -91,7 +91,7 @@ public class Log {
errorTriggeringPolicy.start(); errorTriggeringPolicy.start();
ThresholdFilter thresholdFilter = new ThresholdFilter(); ThresholdFilter thresholdFilter = new ThresholdFilter();
thresholdFilter.setLevel("ERROR"); thresholdFilter.setLevel("WARN");
thresholdFilter.start(); thresholdFilter.start();
errorAppender.setRollingPolicy(errorRollingPolicy); errorAppender.setRollingPolicy(errorRollingPolicy);

8
common/src/main/java/haveno/common/file/FileUtil.java
View file

@ -68,8 +68,7 @@ public class FileUtil {
pruneBackup(backupFileDir, numMaxBackupFiles); pruneBackup(backupFileDir, numMaxBackupFiles);
} catch (IOException e) { } catch (IOException e) {
log.error("Backup key failed: " + e.getMessage()); log.error("Backup key failed: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
} }
} }
@ -97,7 +96,7 @@ public class FileUtil {
try { try {
FileUtils.deleteDirectory(backupFileDir); FileUtils.deleteDirectory(backupFileDir);
} catch (IOException e) { } catch (IOException e) {
e.printStackTrace(); log.error("Delete backup key failed: {}\n", e.getMessage(), e);
} }
} }
@ -173,8 +172,7 @@ public class FileUtil {
} }
} }
} catch (Throwable t) { } catch (Throwable t) {
log.error(t.toString()); log.error("Could not delete file, error={}\n", t.getMessage(), t);
t.printStackTrace();
throw new IOException(t); throw new IOException(t);
} }
} }

9
common/src/main/java/haveno/common/setup/CommonSetup.java
View file

@ -69,11 +69,7 @@ public class CommonSetup {
"The system tray is not supported on the current platform.".equals(throwable.getMessage())) { "The system tray is not supported on the current platform.".equals(throwable.getMessage())) {
log.warn(throwable.getMessage()); log.warn(throwable.getMessage());
} else { } else {
log.error("Uncaught Exception from thread " + Thread.currentThread().getName()); log.error("Uncaught Exception from thread {}, error={}\n", Thread.currentThread().getName(), throwable.getMessage(), throwable);
log.error("throwableMessage= " + throwable.getMessage());
log.error("throwableClass= " + throwable.getClass());
log.error("Stack trace:\n" + ExceptionUtils.getStackTrace(throwable));
throwable.printStackTrace();
UserThread.execute(() -> uncaughtExceptionHandler.handleUncaughtException(throwable, false)); UserThread.execute(() -> uncaughtExceptionHandler.handleUncaughtException(throwable, false));
} }
}; };
@ -113,8 +109,7 @@ public class CommonSetup {
if (!pathOfCodeSource.endsWith("classes")) if (!pathOfCodeSource.endsWith("classes"))
log.info("Path to Haveno jar file: " + pathOfCodeSource); log.info("Path to Haveno jar file: " + pathOfCodeSource);
} catch (URISyntaxException e) { } catch (URISyntaxException e) {
log.error(e.toString()); log.error(ExceptionUtils.getStackTrace(e));
e.printStackTrace();
} }
} }
} }

6
common/src/main/java/haveno/common/taskrunner/TaskRunner.java
View file

@ -25,6 +25,8 @@ import java.util.Arrays;
import java.util.Queue; import java.util.Queue;
import java.util.concurrent.LinkedBlockingQueue; import java.util.concurrent.LinkedBlockingQueue;
import org.apache.commons.lang3.exception.ExceptionUtils;
@Slf4j @Slf4j
public class TaskRunner<T extends Model> { public class TaskRunner<T extends Model> {
private final Queue<Class<? extends Task<T>>> tasks = new LinkedBlockingQueue<>(); private final Queue<Class<? extends Task<T>>> tasks = new LinkedBlockingQueue<>();
@ -67,8 +69,8 @@ public class TaskRunner<T extends Model> {
log.info("Run task: " + currentTask.getSimpleName()); log.info("Run task: " + currentTask.getSimpleName());
currentTask.getDeclaredConstructor(TaskRunner.class, sharedModelClass).newInstance(this, sharedModel).run(); currentTask.getDeclaredConstructor(TaskRunner.class, sharedModelClass).newInstance(this, sharedModel).run();
} catch (Throwable throwable) { } catch (Throwable throwable) {
throwable.printStackTrace(); log.error(ExceptionUtils.getStackTrace(throwable));
handleErrorMessage("Error at taskRunner: " + throwable.getMessage()); handleErrorMessage("Error at taskRunner, error=" + throwable.getMessage());
} }
} else { } else {
resultHandler.handleResult(); resultHandler.handleResult();

3
common/src/main/java/haveno/common/util/Utilities.java
View file

@ -331,8 +331,7 @@ public class Utilities {
clipboard.setContent(clipboardContent); clipboard.setContent(clipboardContent);
} }
} catch (Throwable e) { } catch (Throwable e) {
log.error("copyToClipboard failed " + e.getMessage()); log.error("copyToClipboard failed: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
} }

5
core/src/main/java/haveno/core/api/CoreDisputesService.java
View file

@ -52,6 +52,9 @@ import java.util.ArrayList;
import java.util.Date; import java.util.Date;
import java.util.List; import java.util.List;
import java.util.Optional; import java.util.Optional;
import org.apache.commons.lang3.exception.ExceptionUtils;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
@ -204,7 +207,7 @@ public class CoreDisputesService {
throw new IllegalStateException(errMessage, err); throw new IllegalStateException(errMessage, err);
}); });
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
throw new IllegalStateException(e.getMessage() == null ? ("Error resolving dispute for trade " + trade.getId()) : e.getMessage()); throw new IllegalStateException(e.getMessage() == null ? ("Error resolving dispute for trade " + trade.getId()) : e.getMessage());
} }
} }

4
core/src/main/java/haveno/core/api/CoreTradesService.java
View file

@ -66,6 +66,8 @@ import java.util.List;
import java.util.Optional; import java.util.Optional;
import java.util.function.Consumer; import java.util.function.Consumer;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.exception.ExceptionUtils;
import org.bitcoinj.core.Coin; import org.bitcoinj.core.Coin;
@Singleton @Singleton
@ -161,7 +163,7 @@ class CoreTradesService {
errorMessageHandler errorMessageHandler
); );
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
errorMessageHandler.handleErrorMessage(e.getMessage()); errorMessageHandler.handleErrorMessage(e.getMessage());
} }
} }

12
core/src/main/java/haveno/core/api/XmrConnectionService.java
View file

@ -41,6 +41,9 @@ import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
import java.util.stream.Collectors; import java.util.stream.Collectors;
import org.apache.commons.lang3.exception.ExceptionUtils;
import javafx.beans.property.IntegerProperty; import javafx.beans.property.IntegerProperty;
import javafx.beans.property.LongProperty; import javafx.beans.property.LongProperty;
import javafx.beans.property.ObjectProperty; import javafx.beans.property.ObjectProperty;
@ -464,7 +467,7 @@ public final class XmrConnectionService {
log.info(getClass() + ".onAccountOpened() called"); log.info(getClass() + ".onAccountOpened() called");
initialize(); initialize();
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error("Error initializing connection service after account opened, error={}\n", e.getMessage(), e);
throw new RuntimeException(e); throw new RuntimeException(e);
} }
} }
@ -622,8 +625,7 @@ public final class XmrConnectionService {
log.info("Starting local node"); log.info("Starting local node");
xmrLocalNode.startMoneroNode(); xmrLocalNode.startMoneroNode();
} catch (Exception e) { } catch (Exception e) {
log.warn("Unable to start local monero node: " + e.getMessage()); log.error("Unable to start local monero node, error={}\n", e.getMessage(), e);
e.printStackTrace();
} }
} }
} }
@ -721,8 +723,8 @@ public final class XmrConnectionService {
// log error message periodically // log error message periodically
if (lastLogPollErrorTimestamp == null || System.currentTimeMillis() - lastLogPollErrorTimestamp > HavenoUtils.LOG_POLL_ERROR_PERIOD_MS) { if (lastLogPollErrorTimestamp == null || System.currentTimeMillis() - lastLogPollErrorTimestamp > HavenoUtils.LOG_POLL_ERROR_PERIOD_MS) {
log.warn("Failed to fetch daemon info, trying to switch to best connection: " + e.getMessage()); log.warn("Failed to fetch daemon info, trying to switch to best connection, error={}", e.getMessage());
if (DevEnv.isDevMode()) e.printStackTrace(); if (DevEnv.isDevMode()) log.error(ExceptionUtils.getStackTrace(e));
lastLogPollErrorTimestamp = System.currentTimeMillis(); lastLogPollErrorTimestamp = System.currentTimeMillis();
} }

10
core/src/main/java/haveno/core/app/HavenoExecutable.java
View file

@ -124,7 +124,7 @@ public abstract class HavenoExecutable implements GracefulShutDownHandler, Haven
System.exit(EXIT_FAILURE); System.exit(EXIT_FAILURE);
} catch (Throwable ex) { } catch (Throwable ex) {
System.err.println("fault: An unexpected error occurred. " + System.err.println("fault: An unexpected error occurred. " +
"Please file a report at https://haveno.exchange/issues"); "Please file a report at https://github.com/haveno-dex/haveno/issues");
ex.printStackTrace(System.err); ex.printStackTrace(System.err);
System.exit(EXIT_FAILURE); System.exit(EXIT_FAILURE);
} }
@ -201,8 +201,7 @@ public abstract class HavenoExecutable implements GracefulShutDownHandler, Haven
startApplication(); startApplication();
} }
} catch (InterruptedException | ExecutionException e) { } catch (InterruptedException | ExecutionException e) {
log.error("An error occurred: {}", e.getMessage()); log.error("An error occurred: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
}); });
} }
@ -362,7 +361,7 @@ public abstract class HavenoExecutable implements GracefulShutDownHandler, Haven
try { try {
ThreadUtils.awaitTasks(tasks, tasks.size(), 90000l); // run in parallel with timeout ThreadUtils.awaitTasks(tasks, tasks.size(), 90000l); // run in parallel with timeout
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error("Failed to notify all services to prepare for shutdown: {}\n", e.getMessage(), e);
} }
injector.getInstance(TradeManager.class).shutDown(); injector.getInstance(TradeManager.class).shutDown();
@ -397,8 +396,7 @@ public abstract class HavenoExecutable implements GracefulShutDownHandler, Haven
}); });
}); });
} catch (Throwable t) { } catch (Throwable t) {
log.error("App shutdown failed with exception {}", t.toString()); log.error("App shutdown failed with exception: {}\n", t.getMessage(), t);
t.printStackTrace();
completeShutdown(resultHandler, EXIT_FAILURE, systemExit); completeShutdown(resultHandler, EXIT_FAILURE, systemExit);
} }
} }

3
core/src/main/java/haveno/core/app/HavenoSetup.java
View file

@ -376,8 +376,7 @@ public class HavenoSetup {
moneroWalletRpcFile.setExecutable(true); moneroWalletRpcFile.setExecutable(true);
} }
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Failed to install Monero binaries: {}\n", e.getMessage(), e);
log.warn("Failed to install Monero binaries: " + e.toString());
} }
} }

6
core/src/main/java/haveno/core/app/TorSetup.java
View file

@ -28,6 +28,9 @@ import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.nio.file.Paths; import java.nio.file.Paths;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.apache.commons.lang3.exception.ExceptionUtils;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
@Slf4j @Slf4j
@ -48,8 +51,7 @@ public class TorSetup {
if (resultHandler != null) if (resultHandler != null)
resultHandler.run(); resultHandler.run();
} catch (IOException e) { } catch (IOException e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
log.error(e.toString());
if (errorMessageHandler != null) if (errorMessageHandler != null)
errorMessageHandler.handleErrorMessage(e.toString()); errorMessageHandler.handleErrorMessage(e.toString());
} }

5
core/src/main/java/haveno/core/app/misc/ExecutableForAppWithP2p.java
View file

@ -123,7 +123,7 @@ public abstract class ExecutableForAppWithP2p extends HavenoExecutable {
try { try {
ThreadUtils.awaitTasks(tasks, tasks.size(), 120000l); // run in parallel with timeout ThreadUtils.awaitTasks(tasks, tasks.size(), 120000l); // run in parallel with timeout
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error("Error awaiting tasks to complete: {}\n", e.getMessage(), e);
} }
JsonFileManager.shutDownAllInstances(); JsonFileManager.shutDownAllInstances();
@ -177,8 +177,7 @@ public abstract class ExecutableForAppWithP2p extends HavenoExecutable {
}, 1); }, 1);
} }
} catch (Throwable t) { } catch (Throwable t) {
log.debug("App shutdown failed with exception"); log.info("App shutdown failed with exception: {}\n", t.getMessage(), t);
t.printStackTrace();
PersistenceManager.flushAllDataToDiskAtShutdown(() -> { PersistenceManager.flushAllDataToDiskAtShutdown(() -> {
resultHandler.handleResult(); resultHandler.handleResult();
log.info("Graceful shutdown resulted in an error. Exiting now."); log.info("Graceful shutdown resulted in an error. Exiting now.");

8
core/src/main/java/haveno/core/offer/OpenOfferManager.java
View file

@ -977,7 +977,7 @@ public class OpenOfferManager implements PeerManager.Listener, DecryptedDirectMe
// handle result // handle result
resultHandler.handleResult(null); resultHandler.handleResult(null);
} catch (Exception e) { } catch (Exception e) {
if (!openOffer.isCanceled()) e.printStackTrace(); if (!openOffer.isCanceled()) log.error("Error processing pending offer: {}\n", e.getMessage(), e);
errorMessageHandler.handleErrorMessage(e.getMessage()); errorMessageHandler.handleErrorMessage(e.getMessage());
} }
}).start(); }).start();
@ -1365,9 +1365,8 @@ public class OpenOfferManager implements PeerManager.Listener, DecryptedDirectMe
}); });
result = true; result = true;
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace();
errorMessage = "Exception at handleSignOfferRequest " + e.getMessage(); errorMessage = "Exception at handleSignOfferRequest " + e.getMessage();
log.error(errorMessage); log.error(errorMessage + "\n", e);
} finally { } finally {
sendAckMessage(request.getClass(), peer, request.getPubKeyRing(), request.getOfferId(), request.getUid(), result, errorMessage); sendAckMessage(request.getClass(), peer, request.getPubKeyRing(), request.getOfferId(), request.getUid(), result, errorMessage);
} }
@ -1519,8 +1518,7 @@ public class OpenOfferManager implements PeerManager.Listener, DecryptedDirectMe
result = true; result = true;
} catch (Throwable t) { } catch (Throwable t) {
errorMessage = "Exception at handleRequestIsOfferAvailableMessage " + t.getMessage(); errorMessage = "Exception at handleRequestIsOfferAvailableMessage " + t.getMessage();
log.error(errorMessage); log.error(errorMessage + "\n", t);
t.printStackTrace();
} finally { } finally {
sendAckMessage(request.getClass(), peer, request.getPubKeyRing(), request.getOfferId(), request.getUid(), result, errorMessage); sendAckMessage(request.getClass(), peer, request.getPubKeyRing(), request.getOfferId(), request.getUid(), result, errorMessage);
} }

3
core/src/main/java/haveno/core/provider/fee/FeeProvider.java
View file

@ -59,8 +59,7 @@ public class FeeProvider extends HttpClientProvider {
map.put(Config.BTC_TX_FEE, btcTxFee); map.put(Config.BTC_TX_FEE, btcTxFee);
map.put(Config.BTC_MIN_TX_FEE, btcMinTxFee); map.put(Config.BTC_MIN_TX_FEE, btcMinTxFee);
} catch (Throwable t) { } catch (Throwable t) {
log.error(t.toString()); log.error("Error getting fees: {}\n", t.getMessage(), t);
t.printStackTrace();
} }
return new Tuple2<>(tsMap, map); return new Tuple2<>(tsMap, map);
} }

3
core/src/main/java/haveno/core/provider/price/PriceProvider.java
View file

@ -68,8 +68,7 @@ public class PriceProvider extends HttpClientProvider {
long timestampSec = MathUtils.doubleToLong((Double) treeMap.get("timestampSec")); long timestampSec = MathUtils.doubleToLong((Double) treeMap.get("timestampSec"));
marketPriceMap.put(currencyCode, new MarketPrice(currencyCode, price, timestampSec, true)); marketPriceMap.put(currencyCode, new MarketPrice(currencyCode, price, timestampSec, true));
} catch (Throwable t) { } catch (Throwable t) {
log.error(t.toString()); log.error("Error getting all prices: {}\n", t.getMessage(), t);
t.printStackTrace();
} }
}); });

12
core/src/main/java/haveno/core/support/dispute/DisputeManager.java
View file

@ -83,6 +83,9 @@ import monero.wallet.model.MoneroTxConfig;
import monero.wallet.model.MoneroTxWallet; import monero.wallet.model.MoneroTxWallet;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.apache.commons.lang3.exception.ExceptionUtils;
import java.math.BigInteger; import java.math.BigInteger;
import java.security.KeyPair; import java.security.KeyPair;
import java.time.Instant; import java.time.Instant;
@ -523,7 +526,7 @@ public abstract class DisputeManager<T extends DisputeList<Dispute>> extends Sup
DisputeValidation.validateSenderNodeAddress(dispute, message.getSenderNodeAddress(), config); DisputeValidation.validateSenderNodeAddress(dispute, message.getSenderNodeAddress(), config);
//DisputeValidation.testIfDisputeTriesReplay(dispute, disputeList.getList()); //DisputeValidation.testIfDisputeTriesReplay(dispute, disputeList.getList());
} catch (DisputeValidation.ValidationException e) { } catch (DisputeValidation.ValidationException e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
validationExceptions.add(e); validationExceptions.add(e);
throw e; throw e;
} }
@ -532,9 +535,9 @@ public abstract class DisputeManager<T extends DisputeList<Dispute>> extends Sup
try { try {
DisputeValidation.validatePaymentAccountPayload(dispute); // TODO: add field to dispute details: valid, invalid, missing DisputeValidation.validatePaymentAccountPayload(dispute); // TODO: add field to dispute details: valid, invalid, missing
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
log.warn(e.getMessage());
trade.prependErrorMessage(e.getMessage()); trade.prependErrorMessage(e.getMessage());
throw e;
} }
// get sender // get sender
@ -606,9 +609,8 @@ public abstract class DisputeManager<T extends DisputeList<Dispute>> extends Sup
} }
} }
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
errorMessage = e.getMessage(); errorMessage = e.getMessage();
log.warn(errorMessage);
if (trade != null) trade.setErrorMessage(errorMessage); if (trade != null) trade.setErrorMessage(errorMessage);
} }

4
core/src/main/java/haveno/core/support/dispute/DisputeSummaryVerification.java
View file

@ -71,7 +71,7 @@ public class DisputeSummaryVerification {
disputeAgent = arbitratorManager.getDisputeAgentByNodeAddress(nodeAddress).orElse(null); disputeAgent = arbitratorManager.getDisputeAgentByNodeAddress(nodeAddress).orElse(null);
checkNotNull(disputeAgent, "Dispute agent is null"); checkNotNull(disputeAgent, "Dispute agent is null");
} catch (Throwable e) { } catch (Throwable e) {
e.printStackTrace(); log.error("Error verifying signature: {}\n", e.getMessage(), e);
throw new IllegalArgumentException(Res.get("support.sigCheck.popup.invalidFormat")); throw new IllegalArgumentException(Res.get("support.sigCheck.popup.invalidFormat"));
} }
@ -93,7 +93,7 @@ public class DisputeSummaryVerification {
throw new IllegalArgumentException(Res.get("support.sigCheck.popup.failed")); throw new IllegalArgumentException(Res.get("support.sigCheck.popup.failed"));
} }
} catch (Throwable e) { } catch (Throwable e) {
e.printStackTrace(); log.error("Error verifying signature with agent pub key ring: {}\n", e.getMessage(), e);
throw new IllegalArgumentException(Res.get("support.sigCheck.popup.invalidFormat")); throw new IllegalArgumentException(Res.get("support.sigCheck.popup.invalidFormat"));
} }
} }

7
core/src/main/java/haveno/core/support/dispute/arbitration/ArbitrationManager.java
View file

@ -94,6 +94,8 @@ import java.util.Map;
import java.util.Optional; import java.util.Optional;
import java.util.Set; import java.util.Set;
import org.apache.commons.lang3.exception.ExceptionUtils;
import static com.google.common.base.Preconditions.checkNotNull; import static com.google.common.base.Preconditions.checkNotNull;
@Slf4j @Slf4j
@ -355,7 +357,7 @@ public final class ArbitrationManager extends DisputeManager<ArbitrationDisputeL
requestPersistence(trade); requestPersistence(trade);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error processing dispute closed message: {}", e.getMessage()); log.warn("Error processing dispute closed message: {}", e.getMessage());
e.printStackTrace(); log.warn(ExceptionUtils.getStackTrace(e));
requestPersistence(trade); requestPersistence(trade);
// nack bad message and do not reprocess // nack bad message and do not reprocess
@ -489,8 +491,7 @@ public final class ArbitrationManager extends DisputeManager<ArbitrationDisputeL
try { try {
feeEstimateTx = createDisputePayoutTx(trade, dispute.getContract(), disputeResult, false); feeEstimateTx = createDisputePayoutTx(trade, dispute.getContract(), disputeResult, false);
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Could not recreate dispute payout tx to verify fee: {}\n", e.getMessage(), e);
log.warn("Could not recreate dispute payout tx to verify fee: " + e.getMessage());
} }
if (feeEstimateTx != null) { if (feeEstimateTx != null) {
BigInteger feeEstimate = feeEstimateTx.getFee(); BigInteger feeEstimate = feeEstimateTx.getFee();

9
core/src/main/java/haveno/core/trade/Trade.java
View file

@ -999,8 +999,7 @@ public abstract class Trade extends XmrWalletBase implements Tradable, Model {
xmrWalletService.deleteWallet(getWalletName()); xmrWalletService.deleteWallet(getWalletName());
xmrWalletService.deleteWalletBackups(getWalletName()); xmrWalletService.deleteWalletBackups(getWalletName());
} catch (Exception e) { } catch (Exception e) {
log.warn(e.getMessage()); log.warn("Error deleting wallet for {} {}: {}\n", getClass().getSimpleName(), getId(), e.getMessage(), e);
e.printStackTrace();
setErrorMessage(e.getMessage()); setErrorMessage(e.getMessage());
processModel.getTradeManager().getNotificationService().sendErrorNotification("Error", e.getMessage()); processModel.getTradeManager().getNotificationService().sendErrorNotification("Error", e.getMessage());
} }
@ -1538,8 +1537,7 @@ public abstract class Trade extends XmrWalletBase implements Tradable, Model {
try { try {
ThreadUtils.awaitTask(shutDownTask, SHUTDOWN_TIMEOUT_MS); ThreadUtils.awaitTask(shutDownTask, SHUTDOWN_TIMEOUT_MS);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error shutting down {} {}: {}", getClass().getSimpleName(), getId(), e.getMessage()); log.warn("Error shutting down {} {}: {}\n", getClass().getSimpleName(), getId(), e.getMessage(), e);
e.printStackTrace();
// force close wallet // force close wallet
forceCloseWallet(); forceCloseWallet();
@ -2819,8 +2817,7 @@ public abstract class Trade extends XmrWalletBase implements Tradable, Model {
processing = false; processing = false;
if (!isInitialized || isShutDownStarted) return; if (!isInitialized || isShutDownStarted) return;
if (isWalletConnectedToDaemon()) { if (isWalletConnectedToDaemon()) {
e.printStackTrace(); log.warn("Error polling idle trade for {} {}: {}. Monerod={}\n", getClass().getSimpleName(), getId(), e.getMessage(), getXmrWalletService().getXmrConnectionService().getConnection(), e);
log.warn("Error polling idle trade for {} {}: {}. Monerod={}", getClass().getSimpleName(), getId(), e.getMessage(), getXmrWalletService().getXmrConnectionService().getConnection());
}; };
} }
}, getId()); }, getId());

12
core/src/main/java/haveno/core/trade/TradeManager.java
View file

@ -366,8 +366,7 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
trade.onShutDownStarted(); trade.onShutDownStarted();
} catch (Exception e) { } catch (Exception e) {
if (e.getMessage() != null && e.getMessage().contains("Connection reset")) return; // expected if shut down with ctrl+c if (e.getMessage() != null && e.getMessage().contains("Connection reset")) return; // expected if shut down with ctrl+c
log.warn("Error notifying {} {} that shut down started {}", trade.getClass().getSimpleName(), trade.getId()); log.warn("Error notifying {} {} that shut down started: {}\n", trade.getClass().getSimpleName(), trade.getId(), e.getMessage(), e);
e.printStackTrace();
} }
}); });
try { try {
@ -396,15 +395,13 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
trade.shutDown(); trade.shutDown();
} catch (Exception e) { } catch (Exception e) {
if (e.getMessage() != null && (e.getMessage().contains("Connection reset") || e.getMessage().contains("Connection refused"))) return; // expected if shut down with ctrl+c if (e.getMessage() != null && (e.getMessage().contains("Connection reset") || e.getMessage().contains("Connection refused"))) return; // expected if shut down with ctrl+c
log.warn("Error closing {} {}", trade.getClass().getSimpleName(), trade.getId()); log.warn("Error closing {} {}: {}", trade.getClass().getSimpleName(), trade.getId(), e.getMessage(), e);
e.printStackTrace();
} }
}); });
try { try {
ThreadUtils.awaitTasks(tasks); ThreadUtils.awaitTasks(tasks);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error shutting down trades: {}", e.getMessage()); log.warn("Error shutting down trades: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
} }
@ -462,8 +459,7 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
} }
} catch (Exception e) { } catch (Exception e) {
if (!isShutDownStarted) { if (!isShutDownStarted) {
e.printStackTrace(); log.warn("Error initializing {} {}: {}\n", trade.getClass().getSimpleName(), trade.getId(), e.getMessage(), e);
log.warn("Error initializing {} {}: {}", trade.getClass().getSimpleName(), trade.getId(), e.getMessage());
trade.setInitError(e); trade.setInitError(e);
} }
} }

7
core/src/main/java/haveno/core/trade/protocol/tasks/ArbitratorProcessDepositRequest.java
View file

@ -68,7 +68,7 @@ public class ArbitratorProcessDepositRequest extends TradeTask {
complete(); complete();
} catch (Throwable t) { } catch (Throwable t) {
this.error = t; this.error = t;
t.printStackTrace(); log.error("Error processing deposit request for trade {}: {}\n", trade.getId(), t.getMessage(), t);
trade.setStateIfValidTransitionTo(Trade.State.PUBLISH_DEPOSIT_TX_REQUEST_FAILED); trade.setStateIfValidTransitionTo(Trade.State.PUBLISH_DEPOSIT_TX_REQUEST_FAILED);
failed(t); failed(t);
} }
@ -155,15 +155,14 @@ public class ArbitratorProcessDepositRequest extends TradeTask {
log.info("Arbitrator published deposit txs for trade " + trade.getId()); log.info("Arbitrator published deposit txs for trade " + trade.getId());
trade.setStateIfValidTransitionTo(Trade.State.ARBITRATOR_PUBLISHED_DEPOSIT_TXS); trade.setStateIfValidTransitionTo(Trade.State.ARBITRATOR_PUBLISHED_DEPOSIT_TXS);
} catch (Exception e) { } catch (Exception e) {
log.warn("Arbitrator error publishing deposit txs for trade {} {}: {}", trade.getClass().getSimpleName(), trade.getShortId(), e.getMessage()); log.warn("Arbitrator error publishing deposit txs for trade {} {}: {}\n", trade.getClass().getSimpleName(), trade.getShortId(), e.getMessage(), e);
e.printStackTrace();
if (!depositTxsRelayed) { if (!depositTxsRelayed) {
// flush txs from pool // flush txs from pool
try { try {
daemon.flushTxPool(processModel.getMaker().getDepositTxHash(), processModel.getTaker().getDepositTxHash()); daemon.flushTxPool(processModel.getMaker().getDepositTxHash(), processModel.getTaker().getDepositTxHash());
} catch (Exception e2) { } catch (Exception e2) {
e2.printStackTrace(); log.warn("Error flushing deposit txs from pool for trade {}: {}\n", trade.getId(), e2.getMessage(), e2);
} }
} }
throw e; throw e;

4
core/src/main/java/haveno/core/trade/protocol/tasks/ArbitratorProcessReserveTx.java
View file

@ -29,6 +29,8 @@ import monero.daemon.model.MoneroTx;
import java.math.BigInteger; import java.math.BigInteger;
import org.apache.commons.lang3.exception.ExceptionUtils;
/** /**
* Arbitrator verifies reserve tx from maker or taker. * Arbitrator verifies reserve tx from maker or taker.
* *
@ -73,7 +75,7 @@ public class ArbitratorProcessReserveTx extends TradeTask {
request.getReserveTxKey(), request.getReserveTxKey(),
null); null);
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
throw new RuntimeException("Error processing reserve tx from " + (isFromMaker ? "maker " : "taker ") + processModel.getTempTradePeerNodeAddress() + ", offerId=" + offer.getId() + ": " + e.getMessage()); throw new RuntimeException("Error processing reserve tx from " + (isFromMaker ? "maker " : "taker ") + processModel.getTempTradePeerNodeAddress() + ", offerId=" + offer.getId() + ": " + e.getMessage());
} }

2
core/src/main/java/haveno/core/trade/protocol/tasks/MaybeResendDisputeClosedMessageWithPayout.java
View file

@ -62,7 +62,7 @@ public class MaybeResendDisputeClosedMessageWithPayout extends TradeTask {
HavenoUtils.arbitrationManager.closeDisputeTicket(dispute.getDisputeResultProperty().get(), dispute, dispute.getDisputeResultProperty().get().summaryNotesProperty().get(), () -> { HavenoUtils.arbitrationManager.closeDisputeTicket(dispute.getDisputeResultProperty().get(), dispute, dispute.getDisputeResultProperty().get().summaryNotesProperty().get(), () -> {
completeAux(); completeAux();
}, (errMessage, err) -> { }, (errMessage, err) -> {
err.printStackTrace(); log.error("Failed to close dispute ticket for trade {}: {}\n", trade.getId(), errMessage, err);
failed(err); failed(err);
}); });
ticketClosed = true; ticketClosed = true;

2
core/src/main/java/haveno/core/trade/protocol/tasks/ProcessDepositsConfirmedMessage.java
View file

@ -70,7 +70,7 @@ public class ProcessDepositsConfirmedMessage extends TradeTask {
try { try {
trade.importMultisigHex(); trade.importMultisigHex();
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Error importing multisig hex on deposits confirmed for trade " + trade.getId() + ": " + e.getMessage() + "\n", e);
} }
}); });
} }

2
core/src/main/java/haveno/core/trade/protocol/tasks/TradeTask.java
View file

@ -61,7 +61,7 @@ public abstract class TradeTask extends Task<Trade> {
@Override @Override
protected void failed(Throwable t) { protected void failed(Throwable t) {
t.printStackTrace(); log.error("Trade task failed, error={}\n", t.getMessage(), t);
appendExceptionToErrorMessage(t); appendExceptionToErrorMessage(t);
trade.setErrorMessage(errorMessage); trade.setErrorMessage(errorMessage);
processModel.getTradeManager().requestPersistence(); processModel.getTradeManager().requestPersistence();

4
core/src/main/java/haveno/core/xmr/wallet/XmrWalletBase.java
View file

@ -6,6 +6,8 @@ import java.util.Optional;
import java.util.concurrent.CountDownLatch; import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import org.apache.commons.lang3.exception.ExceptionUtils;
import haveno.common.Timer; import haveno.common.Timer;
import haveno.common.UserThread; import haveno.common.UserThread;
import haveno.core.api.XmrConnectionService; import haveno.core.api.XmrConnectionService;
@ -106,7 +108,7 @@ public class XmrWalletBase {
height = wallet.getHeight(); // can get read timeout while syncing height = wallet.getHeight(); // can get read timeout while syncing
} catch (Exception e) { } catch (Exception e) {
log.warn("Error getting wallet height while syncing with progress: " + e.getMessage()); log.warn("Error getting wallet height while syncing with progress: " + e.getMessage());
if (wallet != null && !isShutDownStarted) e.printStackTrace(); if (wallet != null && !isShutDownStarted) log.warn(ExceptionUtils.getStackTrace(e));
// stop polling and release latch // stop polling and release latch
syncProgressError = e; syncProgressError = e;

32
core/src/main/java/haveno/core/xmr/wallet/XmrWalletService.java
View file

@ -818,7 +818,7 @@ public class XmrWalletService extends XmrWalletBase {
MoneroFeeEstimate feeEstimates = getDaemon().getFeeEstimate(); MoneroFeeEstimate feeEstimates = getDaemon().getFeeEstimate();
BigInteger baseFeeEstimate = feeEstimates.getFees().get(2); // get elevated fee per kB BigInteger baseFeeEstimate = feeEstimates.getFees().get(2); // get elevated fee per kB
BigInteger qmask = feeEstimates.getQuantizationMask(); BigInteger qmask = feeEstimates.getQuantizationMask();
log.info("Monero base fee estimate={}, qmask={}: " + baseFeeEstimate, qmask); log.info("Monero base fee estimate={}, qmask={}", baseFeeEstimate, qmask);
// get tx base fee // get tx base fee
BigInteger baseFee = baseFeeEstimate.multiply(BigInteger.valueOf(txWeight)); BigInteger baseFee = baseFeeEstimate.multiply(BigInteger.valueOf(txWeight));
@ -922,8 +922,7 @@ public class XmrWalletService extends XmrWalletBase {
try { try {
ThreadUtils.awaitTask(shutDownTask, SHUTDOWN_TIMEOUT_MS); ThreadUtils.awaitTask(shutDownTask, SHUTDOWN_TIMEOUT_MS);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error shutting down {}: {}", getClass().getSimpleName(), e.getMessage()); log.warn("Error shutting down {}: {}\n", getClass().getSimpleName(), e.getMessage(), e);
e.printStackTrace();
// force close wallet // force close wallet
forceCloseMainWallet(); forceCloseMainWallet();
@ -945,8 +944,7 @@ public class XmrWalletService extends XmrWalletBase {
List<XmrAddressEntry> unusedAddressEntries = getUnusedAddressEntries(); List<XmrAddressEntry> unusedAddressEntries = getUnusedAddressEntries();
if (!unusedAddressEntries.isEmpty()) return xmrAddressEntryList.swapAvailableToAddressEntryWithOfferId(unusedAddressEntries.get(0), context, offerId); if (!unusedAddressEntries.isEmpty()) return xmrAddressEntryList.swapAvailableToAddressEntryWithOfferId(unusedAddressEntries.get(0), context, offerId);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error getting new address entry based on incoming transactions"); log.warn("Error getting new address entry based on incoming transactions: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
// create new entry // create new entry
@ -1172,8 +1170,7 @@ public class XmrWalletService extends XmrWalletBase {
try { try {
balanceListener.onBalanceChanged(balance); balanceListener.onBalanceChanged(balance);
} catch (Exception e) { } catch (Exception e) {
log.warn("Failed to notify balance listener of change"); log.warn("Failed to notify balance listener of change: {}\n", e.getMessage(), e);
e.printStackTrace();
} }
}); });
} }
@ -1309,8 +1306,7 @@ public class XmrWalletService extends XmrWalletBase {
try { try {
doMaybeInitMainWallet(sync, MAX_SYNC_ATTEMPTS); doMaybeInitMainWallet(sync, MAX_SYNC_ATTEMPTS);
} catch (Exception e) { } catch (Exception e) {
log.warn("Error initializing main wallet: " + e.getMessage()); log.warn("Error initializing main wallet: {}\n", e.getMessage(), e);
e.printStackTrace();
HavenoUtils.setTopError(e.getMessage()); HavenoUtils.setTopError(e.getMessage());
throw e; throw e;
} }
@ -1459,9 +1455,10 @@ public class XmrWalletService extends XmrWalletBase {
log.info("Done creating full wallet " + config.getPath() + " in " + (System.currentTimeMillis() - time) + " ms"); log.info("Done creating full wallet " + config.getPath() + " in " + (System.currentTimeMillis() - time) + " ms");
return walletFull; return walletFull;
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); String errorMsg = "Could not create wallet '" + config.getPath() + "': " + e.getMessage();
log.warn(errorMsg + "\n", e);
if (walletFull != null) forceCloseWallet(walletFull, config.getPath()); if (walletFull != null) forceCloseWallet(walletFull, config.getPath());
throw new IllegalStateException("Could not create wallet '" + config.getPath() + "'"); throw new IllegalStateException(errorMsg);
} }
} }
@ -1525,9 +1522,10 @@ public class XmrWalletService extends XmrWalletBase {
log.info("Done opening full wallet " + config.getPath()); log.info("Done opening full wallet " + config.getPath());
return walletFull; return walletFull;
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); String errorMsg = "Could not open full wallet '" + config.getPath() + "': " + e.getMessage();
log.warn(errorMsg + "\n", e);
if (walletFull != null) forceCloseWallet(walletFull, config.getPath()); if (walletFull != null) forceCloseWallet(walletFull, config.getPath());
throw new IllegalStateException("Could not open full wallet '" + config.getPath() + "'"); throw new IllegalStateException(errorMsg);
} }
} }
@ -1557,7 +1555,7 @@ public class XmrWalletService extends XmrWalletBase {
log.info("Done creating RPC wallet " + config.getPath() + " in " + (System.currentTimeMillis() - time) + " ms"); log.info("Done creating RPC wallet " + config.getPath() + " in " + (System.currentTimeMillis() - time) + " ms");
return walletRpc; return walletRpc;
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Could not create wallet '" + config.getPath() + "': " + e.getMessage() + "\n", e);
if (walletRpc != null) forceCloseWallet(walletRpc, config.getPath()); if (walletRpc != null) forceCloseWallet(walletRpc, config.getPath());
throw new IllegalStateException("Could not create wallet '" + config.getPath() + "'. Please close Haveno, stop all monero-wallet-rpc processes in your task manager, and restart Haveno."); throw new IllegalStateException("Could not create wallet '" + config.getPath() + "'. Please close Haveno, stop all monero-wallet-rpc processes in your task manager, and restart Haveno.");
} }
@ -1629,7 +1627,7 @@ public class XmrWalletService extends XmrWalletBase {
log.info("Done opening RPC wallet " + config.getPath()); log.info("Done opening RPC wallet " + config.getPath());
return walletRpc; return walletRpc;
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Could not open wallet '" + config.getPath() + "': " + e.getMessage() + "\n", e);
if (walletRpc != null) forceCloseWallet(walletRpc, config.getPath()); if (walletRpc != null) forceCloseWallet(walletRpc, config.getPath());
throw new IllegalStateException("Could not open wallet '" + config.getPath() + "'. Please close Haveno, stop all monero-wallet-rpc processes in your task manager, and restart Haveno.\n\nError message: " + e.getMessage()); throw new IllegalStateException("Could not open wallet '" + config.getPath() + "'. Please close Haveno, stop all monero-wallet-rpc processes in your task manager, and restart Haveno.\n\nError message: " + e.getMessage());
} }
@ -1733,7 +1731,7 @@ public class XmrWalletService extends XmrWalletBase {
wallet.changePassword(oldPassword, newPassword); wallet.changePassword(oldPassword, newPassword);
saveMainWallet(); saveMainWallet();
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Error changing main wallet password: " + e.getMessage() + "\n", e);
throw e; throw e;
} }
}); });
@ -1916,7 +1914,7 @@ public class XmrWalletService extends XmrWalletBase {
cacheWalletInfo(); cacheWalletInfo();
requestSaveMainWallet(); requestSaveMainWallet();
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.warn("Error caching wallet info: " + e.getMessage() + "\n", e);
} }
} }
} }

3
desktop/src/main/java/haveno/desktop/main/overlays/windows/DisputeSummaryWindow.java
View file

@ -678,8 +678,7 @@ public class DisputeSummaryWindow extends Overlay<DisputeSummaryWindow> {
closeTicketButton.disableProperty().unbind(); closeTicketButton.disableProperty().unbind();
hide(); hide();
}, (errMessage, err) -> { }, (errMessage, err) -> {
log.error("Error closing dispute ticket: " + errMessage); log.error("Error closing dispute ticket: " + errMessage + "\n", err);
err.printStackTrace();
new Popup().error(err.toString()).show(); new Popup().error(err.toString()).show();
}); });
} }

3
desktop/src/main/java/haveno/desktop/main/portfolio/pendingtrades/TradeSubView.java
View file

@ -153,8 +153,7 @@ public abstract class TradeSubView extends HBox {
tradeStepView.setChatCallback(chatCallback); tradeStepView.setChatCallback(chatCallback);
tradeStepView.activate(); tradeStepView.activate();
} catch (Exception e) { } catch (Exception e) {
log.error("Creating viewClass {} caused an error {}", viewClass, e.getMessage()); log.error("Creating viewClass {} caused an error {}\n", viewClass, e.getMessage(), e);
e.printStackTrace();
} }
} }

13
desktop/src/main/java/haveno/desktop/main/shared/ChatView.java
View file

@ -65,6 +65,7 @@ import javafx.scene.text.TextAlignment;
import javafx.geometry.Insets; import javafx.geometry.Insets;
import org.apache.commons.lang3.exception.ExceptionUtils;
import org.fxmisc.easybind.EasyBind; import org.fxmisc.easybind.EasyBind;
import org.fxmisc.easybind.Subscription; import org.fxmisc.easybind.Subscription;
@ -565,12 +566,10 @@ public class ChatView extends AnchorPane {
inputTextArea.setText(inputTextArea.getText() + "\n[" + Res.get("support.attachment") + " " + result.getName() + "]"); inputTextArea.setText(inputTextArea.getText() + "\n[" + Res.get("support.attachment") + " " + result.getName() + "]");
} }
} catch (java.io.IOException e) { } catch (java.io.IOException e) {
e.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e));
log.error(e.getMessage());
} }
} catch (MalformedURLException e2) { } catch (MalformedURLException e2) {
e2.printStackTrace(); log.error(ExceptionUtils.getStackTrace(e2));
log.error(e2.getMessage());
} }
} }
} else { } else {
@ -593,8 +592,7 @@ public class ChatView extends AnchorPane {
inputTextArea.setText(inputTextArea.getText() + "\n[" + Res.get("support.attachment") + " " + name + "]"); inputTextArea.setText(inputTextArea.getText() + "\n[" + Res.get("support.attachment") + " " + name + "]");
} }
} catch (Exception e) { } catch (Exception e) {
log.error(e.toString()); log.error(ExceptionUtils.getStackTrace(e));
e.printStackTrace();
} }
} }
@ -629,8 +627,7 @@ public class ChatView extends AnchorPane {
try (FileOutputStream fileOutputStream = new FileOutputStream(file.getAbsolutePath())) { try (FileOutputStream fileOutputStream = new FileOutputStream(file.getAbsolutePath())) {
fileOutputStream.write(attachment.getBytes()); fileOutputStream.write(attachment.getBytes());
} catch (IOException e) { } catch (IOException e) {
e.printStackTrace(); log.error("Error opening attachment: {}\n", e.getMessage(), e);
System.out.println(e.getMessage());
} }
} }
} }

4
p2p/src/main/java/haveno/network/Socks5ProxyProvider.java
View file

@ -24,6 +24,7 @@ import haveno.common.config.Config;
import haveno.network.p2p.network.NetworkNode; import haveno.network.p2p.network.NetworkNode;
import java.net.UnknownHostException; import java.net.UnknownHostException;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import org.apache.commons.lang3.exception.ExceptionUtils;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -96,8 +97,7 @@ public class Socks5ProxyProvider {
try { try {
return new Socks5Proxy(tokens[0], Integer.valueOf(tokens[1])); return new Socks5Proxy(tokens[0], Integer.valueOf(tokens[1]));
} catch (UnknownHostException e) { } catch (UnknownHostException e) {
log.error(e.getMessage()); log.error(ExceptionUtils.getStackTrace(e));
e.printStackTrace();
} }
} else { } else {
log.error("Incorrect format for socks5ProxyAddress. Should be: host:port.\n" + log.error("Incorrect format for socks5ProxyAddress. Should be: host:port.\n" +

9
p2p/src/main/java/haveno/network/p2p/P2PService.java
View file

@ -57,6 +57,8 @@ import javafx.beans.property.ReadOnlyIntegerProperty;
import javafx.beans.property.SimpleBooleanProperty; import javafx.beans.property.SimpleBooleanProperty;
import javafx.beans.property.SimpleIntegerProperty; import javafx.beans.property.SimpleIntegerProperty;
import lombok.Getter; import lombok.Getter;
import org.apache.commons.lang3.exception.ExceptionUtils;
import org.fxmisc.easybind.EasyBind; import org.fxmisc.easybind.EasyBind;
import org.fxmisc.easybind.Subscription; import org.fxmisc.easybind.Subscription;
import org.fxmisc.easybind.monadic.MonadicBinding; import org.fxmisc.easybind.monadic.MonadicBinding;
@ -433,15 +435,12 @@ public class P2PService implements SetupListener, MessageListener, ConnectionLis
@Override @Override
public void onFailure(@NotNull Throwable throwable) { public void onFailure(@NotNull Throwable throwable) {
log.error(throwable.toString()); log.error(ExceptionUtils.getStackTrace(throwable));
throwable.printStackTrace();
sendDirectMessageListener.onFault(throwable.toString()); sendDirectMessageListener.onFault(throwable.toString());
} }
}, MoreExecutors.directExecutor()); }, MoreExecutors.directExecutor());
} catch (CryptoException e) { } catch (CryptoException e) {
e.printStackTrace(); log.error("Error sending encrypted direct message, message={}, error={}\n", message.toString(), e.getMessage(), e);
log.error(message.toString());
log.error(e.toString());
sendDirectMessageListener.onFault(e.toString()); sendDirectMessageListener.onFault(e.toString());
} }
} }

3
p2p/src/main/java/haveno/network/p2p/mailbox/MailboxMessageList.java
View file

@ -63,8 +63,7 @@ public class MailboxMessageList extends PersistableList<MailboxItem> {
try { try {
return MailboxItem.fromProto(e, networkProtoResolver); return MailboxItem.fromProto(e, networkProtoResolver);
} catch (ProtobufferException protobufferException) { } catch (ProtobufferException protobufferException) {
protobufferException.printStackTrace(); log.error("Error at MailboxItem.fromProto: {}", protobufferException.toString(), protobufferException);
log.error("Error at MailboxItem.fromProto: {}", protobufferException.toString());
return null; return null;
} }
}) })

6
p2p/src/main/java/haveno/network/p2p/mailbox/MailboxMessageService.java
View file

@ -335,8 +335,7 @@ public class MailboxMessageService implements HashMapChangedListener, PersistedD
} }
}, MoreExecutors.directExecutor()); }, MoreExecutors.directExecutor());
} catch (CryptoException e) { } catch (CryptoException e) {
log.error("sendEncryptedMessage failed"); log.error("sendEncryptedMessage failed: {}\n", e.getMessage(), e);
e.printStackTrace();
sendMailboxMessageListener.onFault("sendEncryptedMailboxMessage failed " + e); sendMailboxMessageListener.onFault("sendEncryptedMailboxMessage failed " + e);
} }
} }
@ -644,8 +643,7 @@ public class MailboxMessageService implements HashMapChangedListener, PersistedD
log.info("The mailboxEntry was already removed earlier."); log.info("The mailboxEntry was already removed earlier.");
} }
} catch (CryptoException e) { } catch (CryptoException e) {
e.printStackTrace(); log.error("Could not remove ProtectedMailboxStorageEntry from network. Error: {}\n", e.toString(), e);
log.error("Could not remove ProtectedMailboxStorageEntry from network. Error: {}", e.toString());
} }
} }

11
p2p/src/main/java/haveno/network/p2p/network/Connection.java
View file

@ -91,6 +91,8 @@ import javafx.beans.property.ObjectProperty;
import javafx.beans.property.SimpleObjectProperty; import javafx.beans.property.SimpleObjectProperty;
import lombok.Getter; import lombok.Getter;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.exception.ExceptionUtils;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
/** /**
@ -511,8 +513,7 @@ public class Connection implements HasCapabilities, Runnable, MessageListener {
Uninterruptibles.sleepUninterruptibly(200, TimeUnit.MILLISECONDS); Uninterruptibles.sleepUninterruptibly(200, TimeUnit.MILLISECONDS);
} catch (Throwable t) { } catch (Throwable t) {
log.error(t.getMessage()); log.error(ExceptionUtils.getStackTrace(t));
t.printStackTrace();
} finally { } finally {
stopped = true; stopped = true;
ThreadUtils.execute(() -> doShutDown(closeConnectionReason, shutDownCompleteHandler), THREAD_ID); ThreadUtils.execute(() -> doShutDown(closeConnectionReason, shutDownCompleteHandler), THREAD_ID);
@ -537,16 +538,14 @@ public class Connection implements HasCapabilities, Runnable, MessageListener {
} catch (SocketException e) { } catch (SocketException e) {
log.trace("SocketException at shutdown might be expected {}", e.getMessage()); log.trace("SocketException at shutdown might be expected {}", e.getMessage());
} catch (IOException e) { } catch (IOException e) {
log.error("Exception at shutdown. " + e.getMessage()); log.error("Exception at shutdown. {}\n", e.getMessage(), e);
e.printStackTrace();
} finally { } finally {
capabilitiesListeners.clear(); capabilitiesListeners.clear();
try { try {
protoInputStream.close(); protoInputStream.close();
} catch (IOException e) { } catch (IOException e) {
log.error(e.getMessage()); log.error(ExceptionUtils.getStackTrace(e));
e.printStackTrace();
} }
Utilities.shutdownAndAwaitTermination(executorService, SHUTDOWN_TIMEOUT, TimeUnit.MILLISECONDS); Utilities.shutdownAndAwaitTermination(executorService, SHUTDOWN_TIMEOUT, TimeUnit.MILLISECONDS);

3
p2p/src/main/java/haveno/network/p2p/network/LocalhostNetworkNode.java
View file

@ -76,8 +76,7 @@ public class LocalhostNetworkNode extends NetworkNode {
try { try {
startServer(new ServerSocket(servicePort)); startServer(new ServerSocket(servicePort));
} catch (IOException e) { } catch (IOException e) {
e.printStackTrace(); log.error("Exception at startServer: {}\n", e.getMessage(), e);
log.error("Exception at startServer: " + e.getMessage());
} }
setupListeners.stream().forEach(SetupListener::onHiddenServicePublished); setupListeners.stream().forEach(SetupListener::onHiddenServicePublished);
}, simulateTorDelayTorNode, TimeUnit.MILLISECONDS); }, simulateTorDelayTorNode, TimeUnit.MILLISECONDS);

5
p2p/src/main/java/haveno/network/p2p/network/Server.java
View file

@ -97,11 +97,10 @@ class Server implements Runnable {
} }
} catch (IOException e) { } catch (IOException e) {
if (isServerActive()) if (isServerActive())
e.printStackTrace(); log.error("Error executing server loop: {}\n", e.getMessage(), e);
} }
} catch (Throwable t) { } catch (Throwable t) {
log.error("Executing task failed. " + t.getMessage()); log.error("Executing task failed: {}\n", t.getMessage(), t);
t.printStackTrace();
} }
} }

3
p2p/src/main/java/haveno/network/p2p/storage/P2PDataStorage.java
View file

@ -974,8 +974,7 @@ public class P2PDataStorage implements MessageListener, ConnectionListener, Pers
broadcaster.broadcast(refreshTTLMessage, sender); broadcaster.broadcast(refreshTTLMessage, sender);
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
log.error("refreshTTL failed, missing data: {}", e.toString()); log.error("refreshTTL failed, missing data: {}\n", e.toString(), e);
e.printStackTrace();
return false; return false;
} }
return true; return true;

3
p2p/src/main/java/haveno/network/p2p/storage/persistence/StoreService.java
View file

@ -116,8 +116,7 @@ public abstract class StoreService<T extends PersistableEnvelope> {
log.debug("Could not find resourceFile " + resourceFileName + ". That is expected if none is provided yet."); log.debug("Could not find resourceFile " + resourceFileName + ". That is expected if none is provided yet.");
} catch (Throwable e) { } catch (Throwable e) {
log.error("Could not copy resourceFile " + resourceFileName + " to " + log.error("Could not copy resourceFile " + resourceFileName + " to " +
destinationFile.getAbsolutePath() + ".\n" + e.getMessage()); destinationFile.getAbsolutePath() + ".\n", e);
e.printStackTrace();
} }
} else { } else {
log.debug("No resource file was copied. {} exists already.", fileName); log.debug("No resource file was copied. {} exists already.", fileName);

2
seednode/src/main/java/haveno/seednode/SeedNodeMain.java
View file

@ -75,7 +75,7 @@ public class SeedNodeMain extends ExecutableForAppWithP2p {
seedNode = new SeedNode(); seedNode = new SeedNode();
UserThread.execute(this::onApplicationLaunched); UserThread.execute(this::onApplicationLaunched);
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); log.error("Error launching seed node: {}\n", e.toString(), e);
} }
}); });
} }