CMake: add TOR_INSTALLED

CMakeLists.txt

@@ -18,15 +18,24 @@ set(COPYRIGHT_HOLDERS "The Monero Project")
 # Configurable options
 option(STATIC "Link libraries statically, requires static Qt" OFF)
 option(SELF_CONTAINED "Disable when building Feather for packages" OFF)
-option(LOCALMONERO "Include LocalMonero module" ON)
+option(STACK_TRACE "Dump stack trace on crash (Linux only)" OFF)
-option(XMRIG "Include XMRig module" ON)
+option(DONATE_BEG "Prompt donation window every once in a while" OFF)
-option(TOR_DIR "Directory containing Tor binaries to embed inside Feather" OFF)
+
+# Updater
 option(CHECK_UPDATES "Enable checking for application updates" OFF)
 option(PLATFORM_INSTALLER "Built-in updater fetches installer (windows-only)" OFF)
-option(USE_DEVICE_TREZOR "Trezor support compilation" ON)
+
-option(DONATE_BEG "Prompt donation window every once in a while" OFF)
+# Tor
+option(TOR_DIR "Directory containing Tor binaries to embed inside Feather" OFF)
+option(TOR_VERSION "Tor version for bundled Tor binary" OFF)
+option(TOR_INSTALLED "Tor binary is available in the installation directory" OFF)
+
+# Components
 option(WITH_SCANNER "Enable webcam QR scanner" ON)
-option(STACK_TRACE "Dump stack trace on crash (Linux only)" OFF)
+option(USE_DEVICE_TREZOR "Trezor support compilation" ON)
+option(LOCALMONERO "Include LocalMonero module" ON)
+option(XMRIG "Include XMRig module" ON)
+
 
 list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake")
 include(CheckCCompilerFlag)

contrib/guix/libexec/build.sh

@@ -279,7 +279,7 @@ mkdir -p "$DISTSRC"
         *mingw32)
             case "$OPTIONS" in
                 installer)
-                    CMAKEVARS+=" -DPLATFORM_INSTALLER=On -DTOR_DIR=Off -DTOR_VERSION=Off"
+                    CMAKEVARS+=" -DPLATFORM_INSTALLER=On -DTOR_DIR=Off -DTOR_VERSION=Off -DTOR_INSTALLED=On"
                     ;;
             esac
             ;;

src/CMakeLists.txt

@@ -187,6 +187,10 @@ if(TOR_DIR)
     target_compile_definitions(feather PRIVATE HAS_TOR_BIN=1)
 endif()
 
+if(TOR_INSTALLED)
+    target_compile_definitions(feather PRIVATE TOR_INSTALLED=1)
+endif()
+
 if(XMRIG)
     target_compile_definitions(feather PRIVATE HAS_XMRIG=1)
 endif()

src/utils/TorManager.cpp

@@ -21,7 +21,7 @@ TorManager::TorManager(QObject *parent)
     connect(m_checkConnectionTimer, &QTimer::timeout, this, &TorManager::checkConnection);
 
     this->torDir = Config::defaultConfigDir().filePath("tor");
-#if defined(PLATFORM_INSTALLER)
+#if defined(TOR_INSTALLED)
     // When installed, use directory relative to application path.
     this->torDir = QDir(Utils::applicationPath()).filePath("tor");
 #endif
@@ -73,10 +73,6 @@ void TorManager::start() {
     }
 
     QFile torFile{this->torPath};
-    QString alternativeTorFile = QCoreApplication::applicationDirPath() + "/tor";
-    if (!torFile.exists() && QFileInfo(alternativeTorFile).isFile()) {
-        this->torPath = alternativeTorFile;
-    }
 
     qDebug() << QString("Start process: %1").arg(this->torPath);
 
@@ -190,7 +186,7 @@ bool TorManager::unpackBins() {
 
     this->torPath = QDir(this->torDir).filePath(torBin);
 
-#if defined(PLATFORM_INSTALLER)
+#if defined(TOR_INSTALLED)
     // We don't need to unpack if Tor was installed using the installer
     return true;
 #endif
@@ -254,7 +250,7 @@ bool TorManager::shouldStartTorDaemon() {
     }
 
     // Don't start a Tor daemon if we don't have one
-#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
+#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
     qWarning() << "Feather built without embedded Tor. Assuming --use-local-tor";
     return false;
 #endif

src/widgets/NetworkProxyWidget.cpp

@@ -44,7 +44,7 @@ NetworkProxyWidget::NetworkProxyWidget(QWidget *parent)
 
     // [Tor settings]
     // [Let Feather start and manage a Tor daemon]
-#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
+#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
     ui->checkBox_torManaged->setChecked(false);
     ui->checkBox_torManaged->setEnabled(false);
     ui->checkBox_torManaged->setToolTip("Feather was bundled without Tor");
@@ -69,7 +69,7 @@ NetworkProxyWidget::NetworkProxyWidget(QWidget *parent)
 
     // [Show Tor logs]
     ui->frame_torShowLogs->setVisible(!config()->get(Config::useLocalTor).toBool());
-#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
+#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
     ui->frame_torShowLogs->setVisible(false);
 #endif
     connect(ui->btn_torShowLogs, &QPushButton::clicked, [this]{