Ecosystem/feather
Ecosystem/feather
1
0
Fork 0
mirror of https://github.com/feather-wallet/feather.git synced 2024-12-22 19:49:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "CMake: add TOR_INSTALLED"

Browse source 
This reverts commit be5fd97fe0.
This commit is contained in:
tobtoht 2023-05-24 21:53:39 +02:00
parent 12aa36a1e3
commit 8f4a306267
No known key found for this signature in database
GPG key ID: E45B10DD027D2472
5 changed files with 18 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
CMakeLists.txt
View file

@ -18,24 +18,15 @@ set(COPYRIGHT_HOLDERS "The Monero Project")
# Configurable options
option(STATIC "Link libraries statically, requires static Qt" OFF)
option(SELF_CONTAINED "Disable when building Feather for packages" OFF)
option(STACK_TRACE "Dump stack trace on crash (Linux only)" OFF)
option(DONATE_BEG "Prompt donation window every once in a while" OFF)
# Updater
option(CHECK_UPDATES "Enable checking for application updates" OFF)
option(PLATFORM_INSTALLER "Built-in updater fetches installer (windows-only)" OFF)
# Tor
option(TOR_DIR "Directory containing Tor binaries to embed inside Feather" OFF)
option(TOR_VERSION "Tor version for bundled Tor binary" OFF)
option(TOR_INSTALLED "Tor binary is available in the installation directory" OFF)
# Components
option(WITH_SCANNER "Enable webcam QR scanner" ON)
option(USE_DEVICE_TREZOR "Trezor support compilation" ON)
option(LOCALMONERO "Include LocalMonero module" ON)
option(XMRIG "Include XMRig module" ON)
option(TOR_DIR "Directory containing Tor binaries to embed inside Feather" OFF)
option(CHECK_UPDATES "Enable checking for application updates" OFF)
option(PLATFORM_INSTALLER "Built-in updater fetches installer (windows-only)" OFF)
option(USE_DEVICE_TREZOR "Trezor support compilation" ON)
option(DONATE_BEG "Prompt donation window every once in a while" OFF)
option(WITH_SCANNER "Enable webcam QR scanner" ON)
option(STACK_TRACE "Dump stack trace on crash (Linux only)" OFF)
list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake")
include(CheckCCompilerFlag)

2
contrib/guix/libexec/build.sh
View file

@ -279,7 +279,7 @@ mkdir -p "$DISTSRC"
*mingw32)
case "$OPTIONS" in
installer)
CMAKEVARS+=" -DPLATFORM_INSTALLER=On -DTOR_DIR=Off -DTOR_VERSION=Off -DTOR_INSTALLED=On"
CMAKEVARS+=" -DPLATFORM_INSTALLER=On -DTOR_DIR=Off -DTOR_VERSION=Off"
;;
esac
;;

4
src/CMakeLists.txt
View file

@ -187,10 +187,6 @@ if(TOR_DIR)
target_compile_definitions(feather PRIVATE HAS_TOR_BIN=1)
endif()
if(TOR_INSTALLED)
target_compile_definitions(feather PRIVATE TOR_INSTALLED=1)
endif()
if(XMRIG)
target_compile_definitions(feather PRIVATE HAS_XMRIG=1)
endif()

10
src/utils/TorManager.cpp
View file

@ -21,7 +21,7 @@ TorManager::TorManager(QObject *parent)
connect(m_checkConnectionTimer, &QTimer::timeout, this, &TorManager::checkConnection);
this->torDir = Config::defaultConfigDir().filePath("tor");
#if defined(TOR_INSTALLED)
#if defined(PLATFORM_INSTALLER)
// When installed, use directory relative to application path.
this->torDir = QDir(Utils::applicationPath()).filePath("tor");
#endif
@ -73,6 +73,10 @@ void TorManager::start() {
}
QFile torFile{this->torPath};
QString alternativeTorFile = QCoreApplication::applicationDirPath() + "/tor";
if (!torFile.exists() && QFileInfo(alternativeTorFile).isFile()) {
this->torPath = alternativeTorFile;
}
qDebug() << QString("Start process: %1").arg(this->torPath);
@ -186,7 +190,7 @@ bool TorManager::unpackBins() {
this->torPath = QDir(this->torDir).filePath(torBin);
#if defined(TOR_INSTALLED)
#if defined(PLATFORM_INSTALLER)
// We don't need to unpack if Tor was installed using the installer
return true;
#endif
@ -250,7 +254,7 @@ bool TorManager::shouldStartTorDaemon() {
}
// Don't start a Tor daemon if we don't have one
#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
qWarning() << "Feather built without embedded Tor. Assuming --use-local-tor";
return false;
#endif

4
src/widgets/NetworkProxyWidget.cpp
View file

@ -44,7 +44,7 @@ NetworkProxyWidget::NetworkProxyWidget(QWidget *parent)
// [Tor settings]
// [Let Feather start and manage a Tor daemon]
#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
ui->checkBox_torManaged->setChecked(false);
ui->checkBox_torManaged->setEnabled(false);
ui->checkBox_torManaged->setToolTip("Feather was bundled without Tor");
@ -69,7 +69,7 @@ NetworkProxyWidget::NetworkProxyWidget(QWidget *parent)
// [Show Tor logs]
ui->frame_torShowLogs->setVisible(!config()->get(Config::useLocalTor).toBool());
#if !defined(HAS_TOR_BIN) && !defined(TOR_INSTALLED)
#if !defined(HAS_TOR_BIN) && !defined(PLATFORM_INSTALLER)
ui->frame_torShowLogs->setVisible(false);
#endif
connect(ui->btn_torShowLogs, &QPushButton::clicked, [this]{