Ecosystem/feather
Ecosystem/feather
1
0
Fork 0
mirror of https://github.com/feather-wallet/feather.git synced 2024-12-23 12:09:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve transaction history CSV export format

Browse source
This commit is contained in:
tobtoht 2021-10-05 14:30:23 +02:00
parent 3721665ea6
commit 0eb4592f87
No known key found for this signature in database
GPG key ID: 1CADD27F41F45C3C
1 changed files with 32 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
src/libwalletqt/TransactionHistory.cpp
View file

@ -6,6 +6,8 @@
#include "utils/Utils.h" #include "utils/Utils.h"
#include "utils/AppData.h" #include "utils/AppData.h"
#include "utils/config.h" #include "utils/config.h"
#include "constants.h"
#include "WalletManager.h"
bool TransactionHistory::transaction(int index, std::function<void (TransactionInfo &)> callback) bool TransactionHistory::transaction(int index, std::function<void (TransactionInfo &)> callback)
{ {
@ -147,13 +149,16 @@ TransactionHistory::TransactionHistory(Monero::TransactionHistory *pimpl, QObjec
} }
bool TransactionHistory::writeCSV(const QString &path) { bool TransactionHistory::writeCSV(const QString &path) {
auto data = QString(""); QString data;
QReadLocker locker(&m_lock); QReadLocker locker(&m_lock);
for (const auto &tx : m_pimpl->getAll()) {
if (tx->subaddrAccount() != 0) { // only account 0
continue;
}
auto transactions = m_pimpl->getAll();
std::sort(transactions.begin(), transactions.end(), [](const Monero::TransactionInfo *info1, const Monero::TransactionInfo *info2){
return info1->blockHeight() < info2->blockHeight();
});
for (const auto &tx : transactions) {
TransactionInfo info(tx, this); TransactionInfo info(tx, this);
// collect column data // collect column data
@ -166,47 +171,46 @@ bool TransactionHistory::writeCSV(const QString &path) {
const double usd_price = appData()->txFiatHistory->get(timeStamp.toString("yyyyMMdd")); const double usd_price = appData()->txFiatHistory->get(timeStamp.toString("yyyyMMdd"));
double fiat_price = usd_price * amount; double fiat_price = usd_price * amount;
if(preferredFiatSymbol != "USD") if (preferredFiatSymbol != "USD")
fiat_price = appData()->prices.convert("USD", preferredFiatSymbol, fiat_price); fiat_price = appData()->prices.convert("USD", preferredFiatSymbol, fiat_price);
double fiat_rounded = ceil(Utils::roundSignificant(fiat_price, 3) * 100.0) / 100.0; double fiat_rounded = ceil(Utils::roundSignificant(fiat_price, 3) * 100.0) / 100.0;
if(fiat_price != 0) if (usd_price != 0)
fiatAmount = QString("%1 %2").arg(QString::number(fiat_rounded)).arg(preferredFiatSymbol); fiatAmount = QString::number(fiat_rounded);
else
fiatAmount = "\"?\"";
// collect some more column data
quint64 atomicAmount = info.atomicAmount();
quint32 subaddrAccount = info.subaddrAccount();
QString fee = info.fee();
QString direction = QString(""); QString direction = QString("");
TransactionInfo::Direction _direction = info.direction(); if (info.direction() == TransactionInfo::Direction_In)
if(_direction == TransactionInfo::Direction_In)
direction = QString("in"); direction = QString("in");
else if(_direction == TransactionInfo::Direction_Out) else if (info.direction() == TransactionInfo::Direction_Out)
direction = QString("out"); direction = QString("out");
else else
continue; // skip TransactionInfo::Direction_Both continue; // skip TransactionInfo::Direction_Both
QString label = info.label();
label.remove(QChar('"')); // reserved
quint64 blockHeight = info.blockHeight();
QString date = info.date() + " " + info.time();
uint epoch = timeStamp.toTime_t();
QString displayAmount = info.displayAmount(); QString displayAmount = info.displayAmount();
QString paymentId = info.paymentId(); QString paymentId = info.paymentId();
if(paymentId == "0000000000000000") if (paymentId == "0000000000000000") {
paymentId = ""; paymentId = "";
}
QString date = QString("%1T%2Z").arg(info.date(), info.time()); // ISO 8601
QString balanceDelta = WalletManager::displayAmount(info.balanceDelta());
if (info.direction() == TransactionInfo::Direction_Out) {
balanceDelta = "-" + balanceDelta;
}
// format and write // format and write
QString line = QString("%1,%2,%3,%4,%5,\"%6\",%7,%8,%9,\"%10\",%11,%12\n") QString line = QString("\n%1,%2,\"%3\",%4,\"%5\",%6,%7,%8,\"%9\",\"%10\",\"%11\",%12,\"%13\"")
.arg(QString::number(blockHeight), QString::number(epoch), date) .arg(QString::number(info.blockHeight()), QString::number(timeStamp.toTime_t()), date,
.arg(direction, QString::number(amount), fiatAmount, QString::number(atomicAmount)) QString::number(info.subaddrAccount()), direction, balanceDelta, info.displayAmount(),
.arg(info.fee(), info.hash(), label, QString::number(subaddrAccount)) info.fee(), info.hash(), info.description(), paymentId, fiatAmount, preferredFiatSymbol);
.arg(paymentId);
data += line; data += line;
} }
if(data.isEmpty()) if (data.isEmpty())
return false; return false;
data = QString("blockHeight,epoch,date,direction,amount,fiat,atomicAmount,fee,txid,label,subaddrAccount,paymentId\n%1").arg(data); data = QString("blockHeight,timestamp,date,accountIndex,direction,balanceDelta,amount,fee,txid,description,paymentId,fiatAmount,fiatCurrency%1").arg(data);
return Utils::fileWrite(path, data); return Utils::fileWrite(path, data);
} }