Ecosystem/cake_wallet
1
0
Fork 0
mirror of https://github.com/cake-tech/cake_wallet.git synced 2025-03-12 09:32:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Change to parentheses

Browse source 
This way we don't need to translate and create different strings for the "on", which will appear odd in languages other than English. I also added it for FIO and OpenAlias.

Further, I removed the 1 instance of openalias_alert_title. It can be removed from the localization file if/when it's convenient.

I did NOT change anything for Unstoppable, because that appeared to touch a dependency. That has its own custom (but similar) text response
This commit is contained in:
Justin Ehrenhofer 2023-01-30 15:18:19 -06:00
parent 9869cd60cc
commit 81f59cacd9
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/entities/parse_address_from_domain.dart
View file

@ -45,14 +45,14 @@ class AddressResolver {
final twitterUser = await TwitterApi.lookupUserByName(userName: formattedName);
final address = extractAddressByType(raw: twitterUser.description ?? '', type: CryptoCurrency.fromString(ticker));
if (address != null) {
return ParsedAddress.fetchTwitterAddress(address: address, name: '$text on Twitter');
return ParsedAddress.fetchTwitterAddress(address: address, name: '$text (Twitter)');
}
}
if (!text.startsWith('@') && text.contains('@') && !text.contains('.')) {
final bool isFioRegistered = await FioAddressProvider.checkAvail(text);
if (isFioRegistered) {
final address = await FioAddressProvider.getPubAddress(text, ticker);
return ParsedAddress.fetchFioAddress(address: address, name: text);
return ParsedAddress.fetchFioAddress(address: address, name: '$text (FIO)');
}
}
@ -77,7 +77,7 @@ class AddressResolver {
final record = await OpenaliasRecord.fetchAddressAndName(
formattedName: formattedName, ticker: ticker);
return ParsedAddress.fetchOpenAliasAddress(record: record, name: text);
return ParsedAddress.fetchOpenAliasAddress(record: record, name: '$text (OpenAlias)');
} catch (e) {
print(e.toString());

2
lib/src/screens/send/widgets/extract_address_from_parsed.dart
View file

@ -19,7 +19,7 @@ Future<String> extractAddressFromParsed(
address = parsedAddress.addresses.first;
break;
case ParseFrom.openAlias:
title = S.of(context).openalias_alert_title;
title = S.of(context).address_detected;
content = S.of(context).openalias_alert_content(parsedAddress.name);
address = parsedAddress.addresses.first;
break;