make CI more strict

.github/workflows/ci.yml

@@ -42,7 +42,10 @@ jobs:
       run: sudo apt install -y libboost-dev
 
     - name: Clippy
-      run: cargo clippy
+      run: cargo clippy --workspace --all-targets --all-features -- -D warnings
+
+    - name: Fmt
+      run: cargo fmt --all --check
 
     - name: Test
       run: cargo test

consensus/src/lib.rs

@@ -4,7 +4,7 @@ use std::{
     sync::Arc,
 };
 
-mod batch_verifier;
+//mod batch_verifier;
 pub mod block;
 pub mod context;
 pub mod genesis;

consensus/src/rpc.rs

@@ -13,7 +13,7 @@ use futures::{
     FutureExt, StreamExt, TryFutureExt, TryStreamExt,
 };
 use tokio::sync::RwLock;
-use tower::{balance::p2c::Balance, util::BoxService, ServiceExt};
+use tower::{balance::p2c::Balance, ServiceExt};
 
 use crate::{helper::rayon_spawn_async, DatabaseRequest, DatabaseResponse};
 

consensus/src/rpc/connection.rs

@@ -20,9 +20,9 @@ use rayon::prelude::*;
 use serde::{Deserialize, Serialize};
 use serde_json::json;
 use tokio::{
+    sync::RwLock,
     task::JoinHandle,
     time::{timeout, Duration},
-    sync::RwLock
 };
 use tower::Service;
 use tracing::{instrument, Instrument};

consensus/src/transactions/inputs.rs

@@ -56,29 +56,6 @@ fn check_decoy_info(decoy_info: &DecoyInfo, hf: &HardFork) -> Result<(), Consens
     Ok(())
 }
 
-/// Checks that the key image is torsion free.
-///
-/// https://cuprate.github.io/monero-book/consensus_rules/transactions.html#torsion-free-key-image
-pub(crate) fn check_key_images_torsion(input: &Input) -> Result<(), ConsensusError> {
-    match input {
-        Input::ToKey { key_image, .. } => {
-            // this happens in monero-serai but we may as well duplicate the check.
-            if !key_image.is_torsion_free() {
-                return Err(ConsensusError::TransactionHasInvalidInput(
-                    "key image has torsion",
-                ));
-            }
-        }
-        _ => {
-            return Err(ConsensusError::TransactionHasInvalidInput(
-                "Input not ToKey",
-            ))
-        }
-    }
-
-    Ok(())
-}
-
 /// Checks the inputs key images for torsion and for duplicates in the transaction.
 ///
 /// The `spent_kis` parameter is not meant to be a complete list of key images, just a list of related transactions
@@ -234,37 +211,6 @@ fn sum_inputs_v1(inputs: &[Input]) -> Result<u64, ConsensusError> {
     Ok(sum)
 }
 
-/// Checks the inputs semantics are  valid.
-///
-/// This does all the checks that don't need blockchain context.
-///
-/// Although technically hard-fork is contextual data we class it as not because
-/// blocks keep their hf in the header.
-pub fn check_inputs_semantics(
-    inputs: &[Input],
-    hf: &HardFork,
-    tx_version: &TxVersion,
-) -> Result<u64, ConsensusError> {
-    if inputs.is_empty() {
-        return Err(ConsensusError::TransactionHasInvalidInput("no inputs"));
-    }
-
-    for input in inputs {
-        check_input_type(input)?;
-        check_input_has_decoys(input)?;
-
-        check_ring_members_unique(input, hf)?;
-        check_key_images_torsion(input)?;
-    }
-
-    check_inputs_sorted(inputs, hf)?;
-
-    match tx_version {
-        TxVersion::RingSignatures => sum_inputs_v1(inputs),
-        _ => panic!("TODO: RCT"),
-    }
-}
-
 /// Checks all input consensus rules.
 ///
 /// TODO: list rules.

p2p/monero-peer/tests/utils.rs

@@ -85,11 +85,11 @@ impl Service<PeerRequest> for DummyPeerRequestHandlerSvc {
     type Future =
         Pin<Box<dyn Future<Output = Result<Self::Response, Self::Error>> + Send + 'static>>;
 
-    fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
+    fn poll_ready(&mut self, _: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
         todo!()
     }
 
-    fn call(&mut self, req: PeerRequest) -> Self::Future {
+    fn call(&mut self, _: PeerRequest) -> Self::Future {
         todo!()
     }
 }